Golden Sun Hacking Community
May 21, 2018, 09:04:53 AM *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News:
 
  Home   Forum   DC Wiki Help Search Calendar Downloads Login Register  
Pages: [1] 2 3   Go Down
  Print  
Author Topic: Minor graphical issues and improvements  (Read 2825 times)
0 Members and 1 Guest are viewing this topic.

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« on: April 25, 2017, 09:39:08 PM »

Hello guys

This is about the minor graphic issue i told earlier today in the chatbox.

As you can see in the first image there are text spillover issues in the character stat box (class line) cause the box isn't symmetrical around the arrow: the first class always fits but the arrow takes a character's space from the second one.

What i want to do: increase the width of the character's box by one character, and while i'm at it, reorganize the other box as well to make the whole thing look even better.

Also, by comparing the "1" and "3" pics you can notice that the djinn icon is not aligned to the box at its right like the psynergy menu one is (as well as the others from ALL other menus).

From a superficial first look I managed to tweak the djinn box (pic 2) but i couldn't find the values for the other box nor the ones for the djinn icon.

The function i studied starts at 0804868C (= Djinn menu), the values i edited to tweak the djinn box are at 080486F4, reduced the first 2 movs by 1 byte and increased the next 2 by one. The pics show my work on the italian version but the addresses here are about the ENG one.

So... does anybody want to investigate this thing with me? :P


* Cattura1.PNG (106.31 KB, 736x538 - viewed 212 times.)

* Cattura2.PNG (121.26 KB, 736x538 - viewed 209 times.)

* Cattura3.PNG (149.3 KB, 736x538 - viewed 184 times.)
« Last Edit: May 14, 2017, 08:16:38 PM by Caledor » Logged
View Profile
Salanewt
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 32
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4566

« Reply #1 on: April 25, 2017, 10:40:15 PM »

Well, for the djinn icon it looks like they moved it over a bit to fit the "[R]: Psynergy Gained" text line in the other window for the English translation, but with your planned changes it could probably be lined up with the other window and not be an issue now.

I can take a quick look soon, there's a pretty good chance that one or both of those things are handled in their own functions. 
Logged

Oh yeah baby, £ me harder.

Fusion is just a cheap tactic to make weak Adepts stronger.

Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« Reply #2 on: April 26, 2017, 06:16:04 AM »

Quick update: I found the other box coords, width and height. They're at 08046518.

I also want to rearrange better the stats so i found the current stats (before the up or down arrow) x pos, starting at 08046654.

Now all that's left to find is the djinn menu icon position, the up down arrow x coord and the stat after the djinn change (after the arrow) x pos. Will look later today.

Edit: found the arrow coord and the new stat x pos too! All that's left is the djinn menu icon position!
Image attached. it's starting to look good!


* Cattura.PNG (82.53 KB, 496x378 - viewed 100 times.)
« Last Edit: April 26, 2017, 10:22:09 AM by Caledor » Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 28
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2411

« Reply #3 on: April 26, 2017, 10:17:41 AM »

@Djinn icon

02035E1C = Battle menu RAM
02035E20 = Should be where the icon's coords are... (etc.)

0804C19C = Y (8-bit)

0804C7BC = X (9-bit)

Well, the final values, anyway. (They are set to 0,0, and then x to 0x80(? Based on SDL-H) or 0x60 (Based on what I quickly looked at in Disassembler.)... or whatever (Only through brief viewing... so didn't figure out what was going on.) ... etc. before being assigned their final value, it seems....)
« Last Edit: April 26, 2017, 10:21:28 AM by Fox » Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Remember kids! Before you go on that interview, remember to wash your hands in teawater! *Coughs on hand* (Excuse me, I just coughed up a little teawater, so they're still clean!) You wouldn't want that hiring manager to be unimpressed.

May the force be with you!
Shoo! Why does it smell in here?
Maybe that's the wrong kind of force. *smirk*
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« Reply #4 on: April 26, 2017, 10:35:05 AM »

Thanks Fox!

I'll edit this post later to show the final result.

Edit: Pics attached! I can't quite decide between v1 and v2 so tell me which one you guys like more.


* old.PNG (71.64 KB, 496x378 - viewed 102 times.)

* v1.PNG (84.47 KB, 496x378 - viewed 102 times.)

* v2.PNG (71.63 KB, 496x378 - viewed 107 times.)
« Last Edit: April 26, 2017, 11:13:14 AM by Caledor » Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 28
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2411

« Reply #5 on: April 26, 2017, 11:22:55 AM »

Looking good! Good job...


@V1/V2: That may be a hard pick..... but I vote V2.


--
You are welcome!
Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Remember kids! Before you go on that interview, remember to wash your hands in teawater! *Coughs on hand* (Excuse me, I just coughed up a little teawater, so they're still clean!) You wouldn't want that hiring manager to be unimpressed.

May the force be with you!
Shoo! Why does it smell in here?
Maybe that's the wrong kind of force. *smirk*
View Profile
Salanewt
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 32
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4566

« Reply #6 on: April 26, 2017, 02:51:27 PM »

I remember having a similar discussion with some of the others a few years ago about the character naming/pre-text crawl screens. I'm more inclined to vote for V1 but with the box height reduced so it's even with the stat window, because it looks weird having that tiny bit of open space being surrounded by boxes. The downside is the icon placement.

Now I'm wondering how it would look if you could fit six djinn entries per window instead of five.
Logged

Oh yeah baby, £ me harder.

Fusion is just a cheap tactic to make weak Adepts stronger.

Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« Reply #7 on: April 26, 2017, 03:24:10 PM »

I'm more inclined to vote for V1 but with the box height reduced so it's even with the stat window

So basically v2's box moved up by one. I briefly considered that but then i thought it'd be the only menu that doesn't start at the bottom of the screen.

Quote
Now I'm wondering how it would look if you could fit six djinn entries per window instead of five.
We have to reduce the space between lines for that to happen, and i honestly have no clue. And I already think i kinda lucked out by finding almost everything so easily with this one lol :P
Logged
View Profile
Salanewt
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 32
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4566

« Reply #8 on: April 26, 2017, 04:23:40 PM »

Lol, makes sense. I'm actually really curious about the line spacing myself, so I'm taking a quick look right now because I'm stumped on the Intellect buff text bugs and want to take a break from that. Nothing yet but I somehow managed to let characters use djinn that they don't have!
Logged

Oh yeah baby, £ me harder.

Fusion is just a cheap tactic to make weak Adepts stronger.

Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 28
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2411

« Reply #9 on: April 26, 2017, 09:39:07 PM »

If you can make six spaces, I'd be interested in knowing if seven slots can be done simply because that's how many each PC has in GS1. So yes, if it is doable, I see a possible patch in your near future?
Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Remember kids! Before you go on that interview, remember to wash your hands in teawater! *Coughs on hand* (Excuse me, I just coughed up a little teawater, so they're still clean!) You wouldn't want that hiring manager to be unimpressed.

May the force be with you!
Shoo! Why does it smell in here?
Maybe that's the wrong kind of force. *smirk*
View Profile
Salanewt
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 32
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4566

« Reply #10 on: April 26, 2017, 09:44:27 PM »

Well, this is what I have so far:


Torch for reference.



I still need to figure out exactly where line spacing happens of course. Based on what I have done so far 7 should be doable at the very least, although I can't say for sure if it will look good or not.

Edit: Actually, I might even be able to fit 10 in here...
« Last Edit: April 26, 2017, 09:46:39 PM by Lord Squirtle » Logged

Oh yeah baby, £ me harder.

Fusion is just a cheap tactic to make weak Adepts stronger.

Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« Reply #11 on: April 27, 2017, 04:17:20 PM »

I was thinking... since I'm already at it I might as well fix the item box as well.

The in battle box for the item menu is smaller than the one shown in the field menu and places a constraint on name length for items.

I've already found all the values i need but one: the coords, width and height for the box that contains the item you're trying to use. See image attached for reference.

Do you guys know where those values are?


* Golden Sun_01.png (17.65 KB, 240x160 - viewed 78 times.)
Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 28
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2411

« Reply #12 on: April 27, 2017, 05:09:25 PM »

The panel call at 0804CA98?
createPanel(x=9,y=17,width=16,height=3,flags=0x6)

(P.S. Found it quickly by using SDL-H, and setting a breakpoint on the 08039260 function...)
« Last Edit: April 27, 2017, 05:12:30 PM by Fox » Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Remember kids! Before you go on that interview, remember to wash your hands in teawater! *Coughs on hand* (Excuse me, I just coughed up a little teawater, so they're still clean!) You wouldn't want that hiring manager to be unimpressed.

May the force be with you!
Shoo! Why does it smell in here?
Maybe that's the wrong kind of force. *smirk*
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 13
Offline Offline

Gender: Male
Posts: 744

« Reply #13 on: April 27, 2017, 06:11:39 PM »

Thanks again Fox!

PS. You know... I really don't like using SDL-H... I don't have the saves there and i always feel like it takes me forever to find something. Still, you gave me a very nice tip that i immediately used to find the psynergy menu version of the box i asked you.

I realized that i can do the same in standard VBA since i've been using a trick to replicate a breakpoint for as long as i can remember. Don't know why it didn't occur to me before :P
Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 28
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2411

« Reply #14 on: April 27, 2017, 06:38:17 PM »

If I recall, I think .sav files work fine.... but there can be incompatibilities with savestates....(If saving from normal VBA and loading through SDL-H.)

You could also try using no$gba debugger as another alternative. (Which is probably easier to use.) In scenarios where it doesn't work, it can be worth making sure you have the bios files. There's a wonderful paradise where those are at. *hint*hint* if you ever need them.

Trick? Let me guessing? Something with having an unconditional branch point to itself? I don't do that myself, but sounds like a neat idea!
Sometimes just looking in the stack for pointers is enough....
« Last Edit: April 27, 2017, 06:49:31 PM by Fox » Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Remember kids! Before you go on that interview, remember to wash your hands in teawater! *Coughs on hand* (Excuse me, I just coughed up a little teawater, so they're still clean!) You wouldn't want that hiring manager to be unimpressed.

May the force be with you!
Shoo! Why does it smell in here?
Maybe that's the wrong kind of force. *smirk*
View Profile
Pages: [1] 2 3   Go Up
  Print  
 
Jump to:  

Cbox
May 09, 2018, 12:35:37 AM
KyleRunner: The "Start In" field is not editable... I'll try making new shortcuts
May 08, 2018, 09:51:08 PM
Fox: If all else fails, you canmake new Shortcuts to do the same thing.
May 08, 2018, 09:49:53 PM
Fox: Export Properties > Shortcut (Tab) > Target / Start In ; Target (for Export) should be: (filename) 0 , and for Import: (filename) 1
May 08, 2018, 08:52:00 PM
KyleRunner: I can't change the path in properties menu...
May 08, 2018, 01:27:19 AM
Fox: You may need to edit something in properties, though... so it uses the exe file in the same directory.
May 08, 2018, 01:24:59 AM
Fox: It is suppose to be a shortcut, yes.
May 03, 2018, 11:48:05 PM
KyleRunner: Fox, the "export" function in your text editor is just a shortcut... Could you please fix it?
May 02, 2018, 09:53:45 PM
KyleRunner: I come here everyday. I'm working on a Portuguese translation, and the people here help me a lot.
May 02, 2018, 08:56:07 AM
Drake baku: My feel as well, I posted a little as well since my return, but silence was all that followed... At least the forum is a great source for data when hacking GS/ GS2, currently looking for something I have read a long time ago cause my PP recovery psy is not working
May 01, 2018, 09:58:04 AM
Fox: I am thinking a lot of this might be because of Discord?
May 01, 2018, 09:56:08 AM
Fox: Yeah, this forum is more dead than ever before.  February and April have 0 new topics. (All other months prior have more.) And March has lowest number of new posts. (It'd be dumb to count the very first month this site was created.)
April 25, 2018, 09:02:13 PM
Fox: Yes. The best tool is a hex editor. Well.... VBA, VBA-SDL-H, no$gba Debugger, GBATEK, and my documentation.... to use these to learn how the code/data works. Best method because it maximizes your editing ability... and then there is my program gsmagic that I was working on. Still in its early stages, though. (Even after year(s).)
April 25, 2018, 04:21:58 PM
Xendrox D: *exept tla editor.
April 25, 2018, 04:21:29 PM
Xendrox D: is there any other tool for hacking gs?
April 23, 2018, 09:26:27 PM
Atrius: Rarely, but not never.
April 23, 2018, 08:01:48 AM
Drake baku: Can it be, the god who created the editor, atrius. I heard you never came back online here anymore
April 20, 2018, 02:46:36 PM
KyleRunner: Atrius!!
April 19, 2018, 11:29:46 PM
Atrius: @Fox, I tried, but for some reason Mario Golf won't boot, and Mario Tennis crashes when you patch out the text compression, and I'm not sure why...  The normal text loading functions in them are basically the same as the ones in the Golden Sun games.
April 16, 2018, 07:44:36 AM
Drake baku: So it took about halve a hour of letting my lap stay off for it to suddenly work again
April 16, 2018, 07:31:28 AM
Drake baku: All of a sudden fox his editor gets errors. When trying to start it, thing worked fine yesterday...

Affiliates
Temple of Kraden Golden Sunrise
Powered by MySQL Powered by PHP Powered by SMF 1.1.21 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!
Page created in 0.066 seconds with 22 queries.