Golden Sun Hacking Community
May 24, 2017, 09:35:46 PM *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News:
 
  Home   Forum   DC Wiki Help Search Calendar Downloads Login Register  
Pages: 1 [2] 3   Go Down
  Print  
Author Topic: Minor graphical issues and improvements  (Read 610 times)
0 Members and 1 Guest are viewing this topic.

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #15 on: April 27, 2017, 07:32:24 PM »

Trick? Let me guessing? Something with having an unconditional branch point to itself?

Yep lol. Write DEFE in the memory viewer and you have a breakpoint. The rest is probably the same as you did, one look at the link registry and i found the panel call.

I always used this trick when i needed to test the functions i changed.
« Last Edit: April 27, 2017, 08:39:03 PM by Caledor » Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 17
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2265

« Reply #16 on: April 27, 2017, 08:33:48 PM »

Okay. Cool. And yeah, I check what is in r14/lr.

Problem though.... Even when you do use that method.... you don't always see the results you want. (Sometimes you do, and then you don't..... it's like the register values can still change... )

It seems to be correct when on mode 0x1F, but I sometimes see mode 0x1B ... (I assume each of the major modes have their own pc/program counter address... (As well as other registers / kinda been knowing something like that-ish, but wasn't really sure how that all worked out.... outside of what I saw as the boot code stuff.)... and that's why.
Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Just because my name is tea doesn't mean I want to be teased.  ... If anyone does it - Consider it an open-invitation to be teased yourself? :P
Glad I'm not Hazewater.... :P
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #17 on: April 27, 2017, 08:38:50 PM »

Okay. Cool. And yeah, I check what is in r14/lr.

Problem though.... Even when you do use that method.... you don't always see the results you want. (Sometimes you do, and then you don't..... it's like the register values can still change... )

Don't know much about modes but i know that when i break that way and go to the disassembler, sometimes the instructions are in the 03xxxxxx range and sometimes in the 00/08xxxxxx range (might actually be this lol) If by pressing next i see the 03 range i click the emulator and try again. if i'm in the 00/08 range i hit next till i return to the breakpoint: this way i'm positive that the registries contains the values i'm looking for.

BTW, everything's done for English TLA: Djinn menu, Item menu and selected item panels are larger; moreover, all selected command/item/psy/summon panels are now centered (as much as possible). I'll release a separate patch for this soon.
« Last Edit: April 27, 2017, 08:46:36 PM by Caledor » Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 17
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2265

« Reply #18 on: April 27, 2017, 08:50:47 PM »

Just looked again... Oh wait... mode 0x1F does the 03 section too... probably Interrupts (whatever that is?), but I will have to check to make sure.
(I think Mode 0x1B was in the BIOS section? - But then, that is just from quick testing, so....)

And awesome! Sounds like a plan.
Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Just because my name is tea doesn't mean I want to be teased.  ... If anyone does it - Consider it an open-invitation to be teased yourself? :P
Glad I'm not Hazewater.... :P
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #19 on: April 27, 2017, 09:45:04 PM »

Patch for TLA is up!
Logged
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #20 on: April 29, 2017, 10:00:13 AM »

Spotted another menu discrepancy between GS and TLA.

Does anybody know how the light blue effect behind the selected item's name is generated? Is there a function call for it?


* Golden Sun_03.png (6.39 KB, 240x160 - viewed 16 times.)

* Golden Sun - L'Era Perduta_04.png (7 KB, 240x160 - viewed 19 times.)
Logged
View Profile
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 17
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2265

« Reply #21 on: April 29, 2017, 12:03:43 PM »

081000A8 = Width of light blue effect

08100024 = Width of the darker blue effect (when clearing the light blue box.)
Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Just because my name is tea doesn't mean I want to be teased.  ... If anyone does it - Consider it an open-invitation to be teased yourself? :P
Glad I'm not Hazewater.... :P
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #22 on: April 29, 2017, 02:03:20 PM »

Done!

It took me a few minutes to figure out that every line had its own parameters (+ the code used branches to avoid some redundancy) but I did it. Thanks again Fox!
Logged
View Profile

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #23 on: May 14, 2017, 08:22:11 PM »

I changed the title to make this one a multi-purpose thread where one can report minor graphical issues and or suggest improvements (that maybe someone will fix/implement):

I'll start with a bug I spotted in the english version of TLA:

The text "(A) Item (L)(R) Switch character" in the status menu, psynergy section, appears briefly and vanishes as soon as the rest of the data appears.

And an improvement that i'm implementing right now in Reloaded:

Show how much criticals are increased in the item info panel (rather than the generic "increased criticals" line).

EDIT: The "show criticals bonus value" has been implemented in reloaded. Anyone can do the same by changing
in TBS: 080A4A80 to 4A94 (little endian)
in TLA: 080FBA18 to BA2C (little endian)


* GSTLA Reloaded_01.png (4.95 KB, 240x160 - viewed 12 times.)

* GSTLA Reloaded_02.png (5.25 KB, 240x160 - viewed 12 times.)
« Last Edit: May 14, 2017, 10:22:40 PM by Caledor » Logged
View Profile
Lord Squirtle
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 26
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4521

« Reply #24 on: May 16, 2017, 08:59:50 PM »

Oh good, you figured out the critical/unleash increase stuff! I was going to tell you about the Intellect patch when I originally saw your post but I haven't been able to sign on lately (because I fixed it in there too but couldn't remember exactly how I did that); would you consider a change that adds the counterattack rate modifier a general aesthetic fix?


Right now, I can think of a few other oddities in GS2:
- Certain utility effects aren't aligned perfectly, so they will be off-centre (Magnet and Arrow for example, but also some others);
- Certain battle animations aren't positioned correctly, like Volcano;
- The battle menu (debug portion at least) has issues with displaying enemy or other sprites that are small or double width;
- Clipping issues with the player avatar on the world map (mainly involving trees, which has a simple explanation) and certain tiles in various maps;
- And a couple other things that aren't coming to mind right now.

This is also a personal opinion thing, but I feel like battle animation palettes lean towards red and purple more often than other colours. This is even represented in the large number of elemental palettes, and especially red and purple palettes compared to colours like green or pink. The animation overhaul allows people to customize several of the 101 animations with ease but aside from that current options are limited.
Logged

And the Wise One is a Mary Sue!

Hey there! I see you over there, looking at me... Wanna come over for a Milk Drink? ;)
Fusion is just a cheap tactic to make weak Adepts stronger.
Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW

I need saves to test encounters in GS Reloaded!

Great Member
***

Coins: 3
Offline Offline

Gender: Male
Posts: 637

« Reply #25 on: May 16, 2017, 11:56:38 PM »

The counterstrike rate bonus has amazing potential... i was thinking of making a bonus to ailment infliction rate out of it. Too bad the value of the bonus isn't stored anywhere in the PC data.

To answer your question about it... as things are now i wouldn't consider a fix. Actually i'd be against it, cause the counterstrike rate line in the info panel would be misleading info.
« Last Edit: May 17, 2017, 12:06:10 AM by Caledor » Logged
View Profile
Rolina
The Fulminous Witch
Jupiter Clan

Template maker turned lurker

Alchemist
*

Coins: 4
Offline Offline

Gender: Female
I am: wondering if we can get our clan position changed...
Clan Position: Grand Overlady of Jupiter
Posts: 5994

« Reply #26 on: May 17, 2017, 12:32:10 AM »

Do y'all know of a way to boost critical rate separately from unleash rate?
Logged

View Profile WWW
Lord Squirtle
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 26
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4521

« Reply #27 on: May 17, 2017, 01:37:59 AM »

Counterstrike rate: That's true. I'm planning to turn it into an actual effect in the AI overhaul and the Intellect patch even adds it to the effect listing and makes it partially functional, but so far it isn't a finished one. All it does is write a bonus total to the same place that the Reflux buff is written, but I have plans!

Spoiler for Plans:
My plan for that is to change the Reflux/counterstrike buff RAM value and double it with an equipment bonus, with a related change to enemy data to add a counterattack rate that people can customize. The bonus will go up to 100 for player characters and 255 for enemies; 100 = 100% counterattack rate, but higher values will correspond to different buff values which can either be enabled through ability effects or on a case by case basis for specific enemies to differentiate between things like Reflux or other effects.

This will be available as a standalone patch as well as part of the AI overhaul, and with it a functional Reflect buff of some sort.

Ailment infliction rate bonus: Funny thing, but I made an ailment resistance bonus as part of the Intellect patch; the downside is that you can't use it through the editor but it's probably for the best given my plans. :p

It has been a while since I released that patch, so I can't really say much about the coding particulars but I would take a look at the bonus in the Intellect patch because it's very close to what you were thinking of doing for infliction rate stuff.


Critical rate: Wasn't it always an unleash rate bonus or am I just mistaken? I was under the assumption that the "critical" part was a bit of a misnomer for it and that a critical rate bonus doesn't actually exist. If that's the case then I'll likely include a critical rate bonus of some kind in the AI overhaul!
« Last Edit: May 17, 2017, 01:46:04 AM by Lord Squirtle » Logged

And the Wise One is a Mary Sue!

Hey there! I see you over there, looking at me... Wanna come over for a Milk Drink? ;)
Fusion is just a cheap tactic to make weak Adepts stronger.
Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW
Fox
Fox McCloud, the Hacking Doctor
Mercury Clan

Prodigy
*

Coins: 17
Offline Offline

I am: certainly not a Gallant!
Clan Position: Head Gallant
Posts: 2265

« Reply #28 on: May 17, 2017, 01:52:03 AM »

Quote
Critical rate: Wasn't it always an unleash rate bonus or am I just mistaken? I was under the assumption that the "critical" part was a bit of a misnomer for it and that a critical rate bonus doesn't actually exist. If that's the case then I'll likely include a critical rate bonus of some kind in the AI overhaul!
If I recall... I'm pretty sure it exists... one is calculated with the unleash rate, and the other is not... but I may need to look this up again.

(I think it was at a different multiplier too... based on which. ... E.g. like either doubled or halved or something... but I can't remember at the moment.... so looking it up. http://forum.goldensunhacking.net/index.php?topic=2448.0)
I really need to get back to that, and document which of those were priority. (Unleash, Crit, Miss)
« Last Edit: May 17, 2017, 02:17:58 AM by Fox » Logged

Golden Sun Docs: Broken Seal - The Lost Age - Dark Dawn | Mario Sports Docs: Mario Golf & Mario Tennis | Misc. Docs
Refer to Yoshi's Lighthouse for any M&L hacking needs...

Just because my name is tea doesn't mean I want to be teased.  ... If anyone does it - Consider it an open-invitation to be teased yourself? :P
Glad I'm not Hazewater.... :P
View Profile
Lord Squirtle
His Sexiness
Mercury Clan

Oh yeah, baby!

Prodigy
*

Coins: 26
Offline Offline

I am: A part of the organization of Cool Cats, but more of a dog person in reality.
Emblems: Have a nice day.
Posts: 4521

« Reply #29 on: May 17, 2017, 02:41:33 AM »

I recall unleashes having priority over everything else but I can't remember of criticals or misses came next, unless I'm mistaken.

Rate: Double or halved? I'm very interested in how that works!



Something else that has always bugged me are field object and character shadows, especially for inanimate objects. A distant goal of mine is to make them translucent and to remove inanimate object shadows, although I need to plan this one out more.

Logged

And the Wise One is a Mary Sue!

Hey there! I see you over there, looking at me... Wanna come over for a Milk Drink? ;)
Fusion is just a cheap tactic to make weak Adepts stronger.
Yoshi's Lighthouse is a hacking website in progress. Why not check it out if you like Yoshi or the Mario & Luigi games?
View Profile WWW
Pages: 1 [2] 3   Go Up
  Print  
 
Jump to:  

Cbox
Today at 06:49:14 PM
Lord Squirtle: I guess I'll make a topic for the GBA concept room in Dark Dawn soon.
Today at 04:27:21 PM
Fox: Yep ... There are many libraries for many languages... Python, etc... And then there are things like  the Google apis - e.g. http://maps.googleapis.com/maps/api/geocode/json?address=(whatever you want to search for)
Today at 07:46:43 AM
Luna_blade: I can see how XML/JSON are a thing these days.
Yesterday at 04:52:18 PM
Fox: Easier in the idea that I can reduce required external stuff where the source code isn't available/modifyable (Well, there is overrides in some cases, but still.) ; So it's possible the only "Events" I would require are those of the Form.... (Mouse Events, Keyboard Events, Paint Events, Etc. when needed.)
Yesterday at 04:42:14 PM
Fox: Anyway... I know I am using built-in controls in my current editor, but it is not out-of-the-question that I might just go and make my own custom controls... so that it is actually easier for me (But that'd take a lot of work.)  I'm thinking about one large bitmap object, and just drawing them on it. Problem is, I'm afraid it might not be efficient enough.  So I haven't decided about doing it.)
Yesterday at 04:33:28 PM
Fox: @XML = If I recall, I believe Visual Studio uses it for Settings Variables that remain even after you close the program. (e.g. There's one variable I have in my program that I call "LastRom" to make it easier to get back into the program.)
Yesterday at 04:17:59 PM
Fox: XML/JSON are simple = They are just a way to store data outside the application... ... The complexity is comparable to learning about data trees, I'd say... XML = Looks like HTML  ; JSON = Think Lists and Dictionaries, and nested ones.
Yesterday at 03:51:19 PM
Luna_blade: @the whole static thing: I recently came across the problem that if you use design patterns, objects of the same class might get duplicate info. Sometimes this is very little information, so it seems better to use something class-wide than making a file
Yesterday at 03:47:41 PM
Luna_blade: another thought I had is that I already made some code better...
Yesterday at 03:45:59 PM
Luna_blade: Sure I will open-source it on github once I rewrite it to be more maintainainable. Now that I think about it, I should put some other stuff there as well
Yesterday at 03:44:54 PM
Luna_blade: Yeah I made some code and screens for it in Java. The last thing I was busy working on was the grid for the values and the selection shape.
Yesterday at 03:41:22 PM
Luna_blade: I will learn a bit of JSON and XML soon. I guess those are pretty good replacements for what I meant with static
Yesterday at 03:40:42 PM
Luna_blade: It's an okay article. I prefer reading the java implementations on tutorialpoint
Yesterday at 12:07:19 PM
Fox: article*
Yesterday at 12:07:06 PM
Fox: Oh yes, there's a whole artice on design patterns at wikipedia? https://en.wikipedia.org/wiki/Software_design_pattern
Yesterday at 07:20:37 AM
Fox: Oh yes.... Just checked.... Program.cs has "Application.Run(new Form1());" ... AND.... Program.cs is a STATIC class, so my hunch is confirmed. (In a way.)
Yesterday at 07:12:43 AM
Fox: So... I'm assuming that it is like a tree, and your top level file should be the static class, with all the other object classes linked from it? (Like a tree?) - Wonder how the Dessigner treats Forms. (How are Form objects linked to a static class, if at all?)
Yesterday at 07:00:51 AM
Fox: (Since I can have incredibly bad wording sometimes :P)
Yesterday at 06:59:50 AM
Fox: (Well, started "?" was more implying whether you made any public releases yet....
Yesterday at 06:59:02 AM
Fox: Wait? You started a Hed Editor? Curious if you were going to open-source it....

Affiliates
Temple of Kraden Golden Sunrise
Powered by MySQL Powered by PHP Powered by SMF 1.1.21 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!
Page created in 0.116 seconds with 23 queries.